2
Vote

Call Dispose in RegionNavigationService if View/View Model implements IDisposable.

description

I have checked source code of RegionNavigationService, and It seems there is no such mechanism. I think it would be a good idea to Dispose view/view model when IRegionMemberLifetime.KeepAlive is false. This is a good practice to put all clean ups in Dispose method such as unregistering static CompositeCommands or disposing DbContext instance in view model (yes, I'm not a fan of Repository pattern :P).

comments

jalalx wrote Mar 16, 2015 at 5:53 AM